Tabnine extension logout menu disappears

[msujew]

Bug Description:

The Tabnine extension removes the logout menu from the authentification menu by "accidentally" sending the same added and removed property in this code. This removes the logout option from then tabnine auth menu. I would usually say this is a plugin issue, but while debugging I've noticed that vscode doesn't receive the same event. Let me break it down:

Theia:

1. Theia receives the added event and adds a logout menu entry for tabnine
2. Roughly ~1 second later it receives another added event together with removed. Both contain the same account information
3. Theia deletes the logout menu entry for tabnine, making it impossible to logout via the menu.

Screenshot for reference:

vscode:

1. VSCode receives the added event adds a logout menu entry for tabnine.

Afterwards, vscode receives no further events.

I've tracked this down to the State that the Tabnine extension receives from its native binary. For some reason the State is different, triggering another round of events. This isn't the case for vscode, even though there's no obvious reason why. Since the login state hasn't actually changed, the plugin will incorrectly add and remove the auth token for Theia in the same event, making it effectively disappear.

Steps to Reproduce:

1. Install the tabnine extension
2. Login
3. Wait a few seconds
4. The logout option should be missing in the auth menu.

Additional Information

• Operating System: Windows
• Theia Version: 1.45.0

[msujew]

My PR codota/tabnine-vscode#1429 has been merged. I'll close this issue once I've tested the upcoming Tabnine release.

[msujew]

This has been fixed in the latest releases of the Tabnine extension.