-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Theia as ESM modules #13272
Comments
@sdirix, @msujew , @JonasHelming and @tsmaeder had a discussion about this and here's a couple of results:
Overall, we decided moving to ESM is a mid-term project that needs more consideration before implementation. |
@tsmaeder Now that VS Code's source code is almost completely ESM (see microsoft/vscode#226260), has anything on that last post changed? Can we still consume everything as is? |
I've prototyped consuming the esm build of VS Code and that seems to work with a couple of webpack magic. As for points 1 and 2 above, I don't think anything has changed. |
Feature Description:
Currently, Theia is published to npm as a bunch of CommonJS modules. This works fine, but might start to have disadvantages in the future:
export
keyword to use the CJS export conventionrequire
function. Webpack can alleviate this problem, unless the modules use "top level async" functionality.The text was updated successfully, but these errors were encountered: