Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook web view iframe is collapsed #13139

Closed
mkhubaibumer opened this issue Dec 1, 2023 · 12 comments · Fixed by #13289
Closed

Notebook web view iframe is collapsed #13139

mkhubaibumer opened this issue Dec 1, 2023 · 12 comments · Fixed by #13289
Assignees
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience
Milestone

Comments

@mkhubaibumer
Copy link

mkhubaibumer commented Dec 1, 2023

Bug Description:

Opening Notebook with interactive widgets and running that with Theia results in collapsed web view iframe and doesn't renders the view properly

Steps to Reproduce:

  1. Clone this open source repository https://github.com/WillKoehrsen/Data-Analysis.git
  2. Open notebook under Data-Analysis/widgets/Widgets-Overview.ipynb
  3. Run the cells

Additional Information

Screenshot 2023-12-01 at 10 42 01 PM

Screen.Recording.2023-12-01.at.10.42.31.PM.mov
  • Operating System: Mac OSX
  • Theia Version: 1.43.0
@msujew msujew added ui/ux issues related to user interface / user experience notebook issues related to notebooks labels Dec 1, 2023
@msujew
Copy link
Member

msujew commented Dec 1, 2023

cc @jonah-iden you might want to take a look at this if you have time.

@JonasHelming
Copy link
Contributor

@jonah-iden @msujew This looks a but like a blocker for the use case, any idea if and when you could look at this?

@jonah-iden
Copy link
Contributor

jonah-iden commented Jan 12, 2024

I'll see if i can take a look next week. Can't promise anything though, since i don't have alot of time left this month for open source projects

@JonasHelming
Copy link
Contributor

@jonah-iden Sounds great! Based on the high quality of this bug report, I would assume @mkhubaibumer could potentially support with testing any fix.

@JonasHelming
Copy link
Contributor

@mkhubaibumer One question, though: Could you quickly verify that the bug still occurs in 1.45?

@bvenreply
Copy link
Contributor

@JonasHelming on my end I can still reproduce the issue on 1.45. I'm also available to test any fix if needed.

@JonasHelming
Copy link
Contributor

@jonah-iden Any chance we can get this fixed in 1.46?

@jonah-iden
Copy link
Contributor

I'll take a look at it today. If its not to complex i should be able to hopefully create a PR today. I just don't have alot of time left this month

@jonah-iden
Copy link
Contributor

jonah-iden commented Jan 19, 2024

@bvenreply im having some issues with running the notebook.
When running the first cell i get Jupyter command jupyter-nbextension not found.
When i ignore that in the secon cell im getting

ImportError: 
The plotly.plotly module is deprecated,
please install the chart-studio package and use the
chart_studio.plotly module instead. 

ignoring that again, installing all neccessary packages and pulling the pandas import down to the data cell the other cells are just running forever without displaying a result when executing

Whats the setup i need to get this running

@bvenreply
Copy link
Contributor

@jonah-iden Sorry I don't know about that specific notebook, I think you should rather ask @mkhubaibumer.

As far as I know the issue arises when rendering any interactive figure created with the plotly library. I can look into creating a small example myself, If I'm able to do so quickly I'll post it here.

@bvenreply
Copy link
Contributor

@jonah-iden Ok I was able to reproduce this very straight-forwardly.

Install python packages in any python environment (just make sure to take note which and use it for the notebook) with pip install -U plotly nbformat

Then create a notebook, create a cell with this code

# x and y given as array_like objects
import plotly.express as px
fig = px.scatter(x=[0, 1, 2, 3, 4], y=[0, 1, 4, 9, 16])
fig.show()

Run the notebook. Results for me, vscode vs Theia:

image

Let me know if you can work with this.

@jonah-iden
Copy link
Contributor

@bvenreply thank you! that example works perfectly for me. I was able to reproduce the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants