Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: untitled text file stays open after closing #12860

Closed
vladarama opened this issue Aug 24, 2023 · 1 comment
Closed

bug: untitled text file stays open after closing #12860

vladarama opened this issue Aug 24, 2023 · 1 comment
Labels
bug bugs found in the application

Comments

@vladarama
Copy link
Contributor

vladarama commented Aug 24, 2023 •
edited
Loading

Bug Description:

If one tries to close an untitled text file, it will stay opened even after saving. The correct behavior would be to close the file once the save is complete.

Bug Demo:
dirty editor latest changes

Steps to Reproduce:

  1. Open Theia Application.
  2. Turn off Auto-Save (File -> Auto-Save).
  3. Create a new untitled text file (File -> New Text File or Alt + N).
  4. Close it by pressing on the X or going to File -> Close Editor.
  5. Save the file.
  6. After it is saved, the editor is still opened, it hasn't been closed.

Additional Information

  • Operating System: Windows 10
  • Theia Version: 1.40
@vince-fugnitto vince-fugnitto added the bug bugs found in the application label Aug 25, 2023
@vladarama vladarama mentioned this issue Sep 13, 2023
Merged
1 task
@vladarama
Copy link
Contributor Author

Closed as completed in #12864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vince-fugnitto @vladarama