Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink Decorator on Folders Appearing as Bubble #11024

Closed
colin-grant-work opened this issue Apr 13, 2022 · 1 comment · Fixed by #10846
Closed

Symlink Decorator on Folders Appearing as Bubble #11024

colin-grant-work opened this issue Apr 13, 2022 · 1 comment · Fixed by #10846
Labels
tree issues related to the tree (ex: tree widget)

Comments

@colin-grant-work
Copy link
Contributor

Bug Description:

Steps to Reproduce:

  1. Symlink a directory into your current workspace
  2. (You may need to refresh the explorer - symlink file changes don't always trigger a refresh automatically)
  3. Observe that the folder shows up in the file explorer with a bubble decoration rather than a symlink decoration.

image

Probably a side-effect of #10820.

Additional Information

  • Operating System: MacOS, Electron
  • Theia Version: master (07dcfbd)
@colin-grant-work colin-grant-work added the tree issues related to the tree (ex: tree widget) label Apr 13, 2022
@vince-fugnitto
Copy link
Member

Probably a side-effect of #10820.

It's a side effect of #9473, where decorations for directories were generalized to always display the dot. We should only display the dot if the children of the directory are decorated, but if the node itself is decorated individually it should apply normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants