Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Contrast Themes Missing Selected Marking for Trees #10111

Closed
3 tasks
colin-grant-work opened this issue Sep 15, 2021 · 4 comments
Closed
3 tasks

High Contrast Themes Missing Selected Marking for Trees #10111

colin-grant-work opened this issue Sep 15, 2021 · 4 comments
Labels
accessibility issues related to accessbilitiy ui/ux issues related to user interface / user experience

Comments

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Sep 15, 2021

Bug Description:

In high-contrast themes, there is no marking of the selected item in trees:

VSCode (note orange border in tree and on tab):

image

Theia (note absence of marking in both tree and tab):

image

Steps to Reproduce:

  1. Open application
  2. Set theme to high-contrast (either one)
  3. Select an item in a tree.
  4. Note that there is no indication of selection

Additional Information

Areas where marking is missing:

  • Trees

  • Tab bars

  • Quick picks
    (Feel free to point out more, if you notice any)

  • Operating System: RHEL7 (Electron)

  • Theia Version: 05f289b

@colin-grant-work colin-grant-work added ui/ux issues related to user interface / user experience accessibility issues related to accessbilitiy labels Sep 15, 2021
@vince-fugnitto
Copy link
Member

@colin-grant-work should we close #6743 in favor of this issue?

@colin-grant-work
Copy link
Contributor Author

It looks like #7353 has about the same amount of detail that I have, so maybe we close this one and #6743 in favor of that?

@vince-fugnitto
Copy link
Member

It looks like #7353 has about the same amount of detail that I have, so maybe we close this one and #6743 in favor of that?

Up to you :) Let's keep one open for sure.

@colin-grant-work
Copy link
Contributor Author

Closing in favor of #6743, which has several more missing high-contrast theme areas in its comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility issues related to accessbilitiy ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

2 participants