Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: there are a number of build errors during CI #164

Closed
vince-fugnitto opened this issue Mar 24, 2023 · 2 comments · Fixed by #165
Closed

errors: there are a number of build errors during CI #164

vince-fugnitto opened this issue Mar 24, 2023 · 2 comments · Fixed by #165

Comments

@vince-fugnitto
Copy link
Member

Description

There are a number of build errors during CI which will need to be addressed:

Example:

Error: lerna ERR! src/browser/hello-world-contribution.ts(14,10): error TS1239: Unable to resolve signature of parameter decorator when called as an expression.
Error: lerna ERR! src/browser/example-file/example-file-command.ts(21,10): error TS1239: Unable to resolve signature of parameter decorator when called as an expression.
Error: src/browser/example-file/example-file-command.ts(21,10): error TS1239: Unable to resolve signature of parameter decorator when called as an expression.
@MenbinX
Copy link

MenbinX commented Mar 28, 2023

I think this issue is caused by latest TypeScript version5.0.2,When I downgrade the TypeScript version, there are no errors

@JonasHelming
Copy link
Contributor

Yes, I can confirm, it seems like this issue: microsoft/TypeScript#52435
The original issue would be fixed by an update of inversify. For a quickfix, I suggest to pin the TypeScript version in the generators to the same as used in Theia, does this work for you @vince-fugnitto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants