Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset preference should set the encoding to UTF-8 #1458

Open
vogella opened this issue Jul 2, 2024 · 5 comments
Open

Reset preference should set the encoding to UTF-8 #1458

vogella opened this issue Jul 2, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@vogella
Copy link
Contributor

vogella commented Jul 2, 2024

If a project does not have an explicit encoding set, we can a warning. But I reset the preference to default, I get encoding from the container. This feels wrong, I suggest we change our default to use UTC-8 encoding.

Current behavior:

Before reset:

image

After reset:

image

@vogella vogella added the bug Something isn't working label Jul 2, 2024
@vogella
Copy link
Contributor Author

vogella commented Jul 2, 2024

I think the basic issue was this one eclipse-platform/eclipse.platform.resources#154

@vogella
Copy link
Contributor Author

vogella commented Jul 2, 2024

Also this one set the UTF-8 default for new workspaces. https://github.com/eclipse-platform/eclipse.platform.resources/pull/51/files but restore defaults still changes it to inherit from container.

@jukzi jukzi changed the title Reset preference should set the encoding to UTC-8 Reset preference should set the encoding to UTF-8 Jul 2, 2024
@jukzi
Copy link
Contributor

jukzi commented Jul 2, 2024

+1 reset workspace should always be the same state as in new workspace

@vogella
Copy link
Contributor Author

vogella commented Jul 3, 2024

Not sure there the default is set, /org.eclipse.core.resources/src/org/eclipse/core/internal/resources/PreferenceInitializer.java seems to not involved it the preference page setting. I think we should also set in this page UTF-8 as default but that has no direct impact on the preference page default.

@vogella
Copy link
Contributor Author

vogella commented Jul 3, 2024

#1462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants