-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset preference should set the encoding to UTF-8 #1458
Comments
I think the basic issue was this one eclipse-platform/eclipse.platform.resources#154 |
Also this one set the UTF-8 default for new workspaces. https://github.com/eclipse-platform/eclipse.platform.resources/pull/51/files but restore defaults still changes it to inherit from container. |
+1 reset workspace should always be the same state as in new workspace |
Not sure there the default is set, /org.eclipse.core.resources/src/org/eclipse/core/internal/resources/PreferenceInitializer.java seems to not involved it the preference page setting. I think we should also set in this page UTF-8 as default but that has no direct impact on the preference page default. |
If a project does not have an explicit encoding set, we can a warning. But I reset the preference to default, I get encoding from the container. This feels wrong, I suggest we change our default to use UTC-8 encoding.
Current behavior:
Before reset:
After reset:
The text was updated successfully, but these errors were encountered: