Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modern light theme: secondary views with wrong contrast #2200

Open
jukzi opened this issue Aug 16, 2024 · 7 comments
Open

modern light theme: secondary views with wrong contrast #2200

jukzi opened this issue Aug 16, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@jukzi
Copy link
Contributor

jukzi commented Aug 16, 2024

As far as i understand every View but the Editor is supposed to have low contrast but currently it is a wild mixture of shades

Examples:

JUnit Stack trace part:
image
History VIew:
image
Problem Views, Error Log Title:
image
image
Console:
image

Also the items in the Problems View have even are darker background then the other views
image

@jukzi jukzi added the bug Something isn't working label Aug 16, 2024
@merks
Copy link
Contributor

merks commented Aug 16, 2024

For EMF-based editors, the properties view is a principle focal point when editing a model. Here is how things used to look:

image

This is how it looks now:

image

It's hard to tell what really has focus because there's always a blue under/over-line. The underlining of the tabbed page in the eidtor is different from the rest of the underlining, and changes color depending on focus. The breadcrumbs have some white stuff in them that I never seen before. Where did that come from?

Ranting constructively, this is one of the things that drive me to despair with theming. I might set a color, but something else will change that color and in the end I have no clue of how I can set colors such that all these different themes won't produce something completely unreadable in some cases. Basically one has to test every editor, view, and dialog on every theme, and even then I'm often left wondering, how do I fix this?

@BeckerWdf
Copy link
Contributor

The breadcrumbs have some white stuff in them that I never seen before. Where did that come from?

@mvm-sap: Can you answer this question?

@BeckerWdf
Copy link
Contributor

Ranting constructively

I like that term ;-)

this is one of the things that drive me to despair with theming. I might set a color, but something else will change that color and in the end I have no clue of how I can set colors such that all these different themes won't produce something completely unreadable in some cases. Basically one has to test every editor, view, and dialog on every theme, and even then I'm often left wondering, how do I fix this?

I really agree.

@akurtakov
Copy link
Member

That's the biggest issue with theming - one either has to set EVERY color everywhere or such discrepancies will happen. It's one of the reasons why SWT by default tries to not hardcode colors but rather use the respective OS defined colors as we would most likely never have the manpower and designing capabilities of an OS developing company.

@mvm-sap
Copy link
Contributor

mvm-sap commented Aug 19, 2024

The breadcrumbs have some white stuff in them that I never seen before. Where did that come from?

Yes, we wanted the background of breadcrumbs to have the same color as the text editor, hence set the background of composites in the compatibility editor to white. But, each item in the breadcrumb is not picking that as jdt has set to grey in their theming extension. I can revert those changes, so that it is completely grey and each plugin has to customize it with white background for breadcrumbs in their respective CSS extension

@BeckerWdf
Copy link
Contributor

For EMF-based editors, the properties view is a principle focal point when editing a model. Here is how things used to look:

image

This is how it looks now:

image

It's hard to tell what really has focus because there's always a blue under/over-line. The underlining of the tabbed page in the eidtor is different from the rest of the underlining, and changes color depending on focus. The breadcrumbs have some white stuff in them that I never seen before. Where did that come from?

Ranting constructively, this is one of the things that drive me to despair with theming. I might set a color, but something else will change that color and in the end I have no clue of how I can set colors such that all these different themes won't produce something completely unreadable in some cases. Basically one has to test every editor, view, and dialog on every theme, and even then I'm often left wondering, how do I fix this?

@merks: Can you pls. verify again with today's version of the "Light (Preview)" theme? Are the issues still there?

@jukzi
Copy link
Contributor Author

jukzi commented Sep 30, 2024

Type hierarchy: same error:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants