Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips of Tool items do not not show updated key bindings once updated from preferences #1466

Open
umairsair opened this issue Jan 4, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@umairsair
Copy link
Contributor

Steps

  1. Start fresh workspace.
  2. Go to Windows > Preferences > General > Keys.
  3. Update the key binding of "Redo".
    image
  4. Apply and Close
  5. Hover over Redo tool item and it'll still show old key binding in tooltip.
    image
@umairsair umairsair added the bug Something isn't working label Jan 4, 2024
@lathapatil
Copy link
Contributor

ToolTip is getting updated once the redo icon changes the state from disabled to enabled and vice versa.

@umairsair
Copy link
Contributor Author

ToolTip is getting updated once the redo icon changes the state from disabled to enabled and vice versa.

Yes. Or when clicked if tool item is already enabled.

@Dinesh0723
Copy link
Contributor

I have tested in the latest Eclipse SDK version: 2024-03 (4.31) with build ID: I20240225-1800, and it is working fine. Please refer to the attached video,

2024-02-26_16h37_18.mp4

@umairsair
Copy link
Contributor Author

It would have been good if you also show the tooltip before changing the binding.

@Dinesh0723
Copy link
Contributor

It would have been good if you also show the tooltip before changing the binding.

Please refer the attached video,

2024-02-26_16h55_37.mp4

@umairsair
Copy link
Contributor Author

Can you please check on linux host. I quickly tried on linux with same build and issue is reproducible there.

@Dinesh0723
Copy link
Contributor

@umairsair, Looks like an SWT issue. When I check out the latest SWT source in the SDK, the problem doesn't occur. However, when I close the checked-out SWT source projects from Eclipse SDK (Version: 2024-03 (4.31), Build id: I20240226-1800), the issue reappears.

@SyntevoAlex, @Phillipus, As a newcomer to SWT, I'm curious about the potential root cause of this. Have you faced this kind of issues in SWT?

@Phillipus
Copy link
Contributor

Phillipus commented Mar 1, 2024

@SyntevoAlex, @Phillipus, As a newcomer to SWT, I'm curious about the potential root cause of this. Have you faced this kind of issues in SWT?

I didn't see this problem in our RCP app. I see it sometimes in Eclipse 4.30 but not 4.31

@Dinesh0723
Copy link
Contributor

The issue is reproducible only in Eclipse version 4.31 but not in version 4.32. I have tested in the latest Eclipse SDK version: 2024-06 (4.32), and the problem does not occur in both Windows and Linux environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants