Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug-In Image browser does not highlight the current page in dark theme #822

Open
lathapatil opened this issue Oct 26, 2023 · 0 comments · May be fixed by #904
Open

Plug-In Image browser does not highlight the current page in dark theme #822

lathapatil opened this issue Oct 26, 2023 · 0 comments · May be fixed by #904

Comments

@lathapatil
Copy link
Contributor

Reference : eclipse-platform/eclipse.platform.ui#1168

eclipse-platform/eclipse.platform.ui#1168 (comment)

Due to precedence of Dark theme Hyperlinks in Pagination control is not reflecting its actual color (blue).
Temporary fix can be done by disabling the styling for current page (Hyperlink widget) and setting white color to it (only if current theme is Dark Theme ).

Actual fix can be done as part of this issue.
lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Nov 10, 2023
@lathapatil
Plug-In Image browser does not highlight the current page in dark theme
f1ab46e 
Temporary fix to disable the styling for current page (Hyperlink widget)
and setting white color to it (only if current theme is Dark Theme ).

Fixes eclipse-pde#822
@lathapatil lathapatil linked a pull request Nov 10, 2023 that will close this issue
Open
lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Nov 15, 2023
@lathapatil
Plug-In Image browser does not highlight the current page in dark theme
3337ee3 
Temporary fix to disable the styling for current page (Hyperlink widget)
and setting white color to it (only if current theme is Dark Theme ).

Fixes eclipse-pde#822
lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Dec 7, 2023
@lathapatil
Plug-In Image browser does not highlight the current page in dark theme
65e8b4f 
Temporary fix to disable the styling for current page (Hyperlink widget)
and setting white color to it (only if current theme is Dark Theme ).

Fixes eclipse-pde#822
laeubi pushed a commit to lathapatil/eclipse.pde that referenced this issue Jan 27, 2024
@lathapatil @laeubi
Plug-In Image browser does not highlight the current page in dark theme
9dbbe52 
Temporary fix to disable the styling for current page (Hyperlink widget)
and setting white color to it (only if current theme is Dark Theme ).

Fixes eclipse-pde#822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plug-In Image browser does not highlight the current page in dark theme lathapatil/eclipse.pde
1 participant
@lathapatil