Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Z CS support out of OMR and into OpenJ9 #3278

Closed
fjeremic opened this issue Oct 15, 2018 · 1 comment
Closed

Move Z CS support out of OMR and into OpenJ9 #3278

fjeremic opened this issue Oct 15, 2018 · 1 comment

Comments

@fjeremic
Copy link
Contributor

The CS support currently in OMR is very VM dependent. For example the J9GSParamenters struct that is reference throughout the implementation is only defined in OpenJ9 [1] [2]. Furthermore the software based implementation of CS in OMR relies on offsets in J9VMThread which are very VM specific and also relies on specific implementation details within OpenJ9.

As such we need to migrate our implementation from OMR and into OpenJ9 by making use of the new read barrier IL introduced by the x86 codegen team as part of the x86 software CS implementation in #3054.

This will involve adding new evaluators on Z and removing the "tree anchoring" hack that we currently do in OMR.

[1] https://github.com/eclipse/openj9/blob/3acd9df17c63a61eed8c329b6e250e22c0fe5f89/runtime/oti/j9nonbuilder.h#L5000-L5003
[2] https://github.com/eclipse/openj9/blob/90844424cf6b415acebc4916cea72e3fc6978b0f/runtime/oti/j9port_generated.h#L119-L130

@fjeremic
Copy link
Contributor Author

Fixed as part of #5183.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants