-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[playground] Parser definition error seem to break the playground #130
Comments
@montymxb Your example works for me with the current playground. |
But I detected the same behaviour with another grammar which fails due to left-recursion. The grammar editor shows no error message, the content editor is "Loading ..." or shows some content without language support. |
@JohannesMeierSE I believe that it used to fail due to a statically identified lookahead ambiguity. Since switching to an LL(*) lookahead, that's not an issue anymore. But other grammar errors still result in breakage. |
Yes, failing of the grammar is expected and OK, but the user experience in the playground is bad, since as user I expect an error marker in the grammar editor and not a "no-response" with the error message hidden in the browser console ... |
Here's an example of a user writing a grammar in the Playground and not seeing the "Ambiguous Alternatives Detected" parser error, which is only printed in the console: We should make such parser validation errors visible in the Playground UI. |
Clearing the assignee so anyone can take this. @Lotes feel free to take it back if you'd like to work on this. |
By the way, I believe the original issue here as been resolved in #171. |
Using this Grammar produce a chevrotain parser definition error.
Now if one tries to edit the grammar to correct the syntax, model editor shows 'Loading...' but nothing happens.
Browser also reports an error in the console:
Unhandled Promise Rejection: monaco-languageclient start was unsuccessful: Request initialize failed with message: Parser Definition Errors detected:
The text was updated successfully, but these errors were encountered: