Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JDT onboarding icon for the black theme #538

Open
vogella opened this issue Apr 19, 2023 · 6 comments · May be fixed by #594
Open

Improve JDT onboarding icon for the black theme #538

vogella opened this issue Apr 19, 2023 · 6 comments · May be fixed by #594

Comments

@vogella
Copy link
Contributor

vogella commented Apr 19, 2023

Similar to eclipse-pde/eclipse.pde#581 the JDT onboarding icon should be improved to look good in the dark theme and the light theme.

Current icon:

image

cc @BeckerWdf
@BeckerWdf
Copy link
Contributor

What do you finde wrong? You would like to remove the fill? This looks odd then - I tried that.

@vogella vogella changed the title Improve PDE onboarding icon for the black theme Improve JDT onboarding icon for the black theme Apr 24, 2023
@vogella
Copy link
Contributor Author

vogella commented Apr 24, 2023

What do you finde wrong? You would like to remove the fill? This looks odd then - I tried that.

Maybe with some transparency?

@BeckerWdf
Copy link
Contributor

What do you finde wrong? You would like to remove the fill? This looks odd then - I tried that.

Maybe with some transparency?

It already has transparency. See:

Screenshot 2023-04-27 at 10 11 29

I put a read shape behind the icon just to make this visible for you.

I don't find it too light in dark theme.

@jukzi
Copy link
Contributor

jukzi commented May 24, 2023

I like the reduced contrast on PDE's image more, because it does not attract so much focus:
image

@BeckerWdf
Copy link
Contributor

I like the reduced contrast on PDE's image more, because it does not attract so much focus: image

So what do you propose?

@jukzi
Copy link
Contributor

jukzi commented May 24, 2023

use same colors as in PDE as shown in pasted image

BeckerWdf added a commit to BeckerWdf/eclipse.jdt.ui that referenced this issue May 25, 2023
@BeckerWdf
Improve JDT onboarding icon for the black theme
c158dbe 
Fixes: eclipse-jdt#538
@BeckerWdf BeckerWdf linked a pull request May 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve JDT onboarding icon for the black theme BeckerWdf/eclipse.jdt.ui
3 participants
@vogella @BeckerWdf @jukzi