Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23][IDE Support] JEP 477: Implicitly Declared Classes and Instance Main Methods (Third Preview) #2474 #2847

Closed
Tracked by #2212
mpalat opened this issue Aug 22, 2024 · 4 comments
Milestone

Comments

@mpalat
Copy link
Contributor

mpalat commented Aug 22, 2024

IDE Support for issue #2474

DOM AST + Rewrite
Search
Selection
Content Assist
Formatter
Create issues as required.

@mpalat
Copy link
Contributor Author

mpalat commented Aug 26, 2024

@jarthana can you please take a look whether something is needed here? I am wondering what will be shown in AST View [AST DOM usage] for example? And for a search for the implicit class? Type hierarchy etc..

@jarthana
Copy link
Member

Other than search, of which I don't have much idea, I don't think we need anything here. I can see DOM nodes being added and functioning as expected and code assist in general working. I think some of the list is irrelevant, like the type hierarchy.

I tried some basic things with search that appear to be working. But as an expert in this area, I will let you decide whether something else is required here.

@stephan-herrmann
Copy link
Contributor

Other than search

I don't think that implicit classes are really relevant for search, as no-one outside can see them, right?

Has anyone tried to format an implicit class?

@mpalat
Copy link
Contributor Author

mpalat commented Sep 18, 2024

Other than search

I don't think that implicit classes are really relevant for search, as no-one outside can see them, right?

right, search not relevant here. @subyssurendran666 is adding search testcases via issue #2907

Has anyone tried to format an implicit class?

Formatter support will be tracked via issue #2977

am closing this issue - individual issues will track the above items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants