Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Switch workspace (for easy pull request review) #240

Open
chris-volk opened this issue Jul 3, 2024 · 3 comments
Open

[Task] Switch workspace (for easy pull request review) #240

chris-volk opened this issue Jul 3, 2024 · 3 comments
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.

Comments

@chris-volk
Copy link
Contributor

As a reviewer of a pull request of an Aspect Model (e.g. Catena-X) I want to keep my previous work in the editor, switch the workspace folder to a folder that represents the pull request context (model and all referred models (transitively)) so that I can understand and review the pull request easily and afterwards revert back to my original work context.
The process and best practice for retrieving the pull request context shall also be documented as part of this issue.

Describe alternatives you've considered
The current workaround is to manually backup your local workspace folder.

Additional context
This issue requires the consideration of file access on each supported platform and potentially required administrative rights

@chris-volk chris-volk added the acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. label Jul 3, 2024
@chris-volk
Copy link
Contributor Author

Consider to add multiple sources (github, multiple folders, ...) and have the github context priority.

@chris-volk
Copy link
Contributor Author

chris-volk commented Jul 9, 2024

Requirement 1: I want to continue my other Aspect Modeling Work later
Requirement 2 (for users without git experience): I want to open the mentioned Aspects from the review in the Aspect Model Editor together with the references (context) from the pull request -> instructions how to install git client or github desktop or download zip from pull request
Requirement 3a (for users experienced in git): If I have a git client installed I want the aspect model editor to listen to file changes and propose reloading so that I am able to switch branches to a pull request back and forth and review in the editor and afterwards review (already possible with Workspace refresh icon on the left frame, but can this be automatic?)
Requirement 3b: I want to define my workspace root folder (new folder or one of the previously configured ones) so that I am able to use a folder which is used for git

@chris-volk
Copy link
Contributor Author

Also fix bug that second level folders are currently interpreted by the workspace:

Expected: second level folders are ignored.
Actual: concatenated path as namespace.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.
Projects
None yet
Development

No branches or pull requests

1 participant