Fix CClassInfoConstructor #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llName Signed-off-by: Dietrich Schulten <[email protected]>
dschulten
force-pushed
the
1114-cclassinfo-constructor-fullname
branch
from
7b9a025 to
56baba5
Compare
|
This should also be backported to 2.3.x, but I am unsure how to proceed. Should I create a PR against the 2.3.2-RI-RELEASE branch? |
|
There is no branch for 2.x and no plan for that yet. At least not till 3.0 gets out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1114
Use lastIndexOf to construct the correct parent and shortName from fullname.