Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher should not touch server.log #24065

Open
dmatej opened this issue Aug 3, 2022 · 2 comments
Open

Launcher should not touch server.log #24065

dmatej opened this issue Aug 3, 2022 · 2 comments
Assignees
Milestone

Comments

@dmatej
Copy link
Contributor

dmatej commented Aug 3, 2022

The first log record in server.log is not printed by the server, but by it's launcher. That means ...

  • the launcher prints the log even if the server startup failed. The cause is not printed anywhere.

    • it would be better if it would print this log record and the cause to the stderr instead.
    • the log leads to a confusion aka "server logged something into the server.log, so i started ... and then crashed" while it did not start at all.
  • the launcher uses it's own configuration and ignores server's logging.properties

    • it should have own configuration and own file OR stderr+stdout
    • first log record can have different log format than what is configured for the server.log
  • refactoring required, there is quite a lot of copy&paste, dead code, etc.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

Copy link

github-actions bot commented Aug 4, 2024

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant