Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] Ephemeral workspaces cannot load plugins #14749

Closed
1 task done
amisevsk opened this issue Oct 2, 2019 · 8 comments
Closed
1 task done

[regression] Ephemeral workspaces cannot load plugins #14749

amisevsk opened this issue Oct 2, 2019 · 8 comments
Assignees
@amisevsk
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone
7.3.0

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Oct 2, 2019

Describe the bug

When running a workspace in ephemeral mode on Che 7.2, no plugins can be loaded.

This appears to be due to a change in how volumes are mounted. In non-ephemeral mode, we have

plugins, subpath workspaceyo32yti5y6vqno7a/plugins/ → /plugins

whereas in ephemeral mode, the mount is

plugins → /plugins

which causes the plugin artifacts to be stored at /plugins/<workspace-id>/plugins/sidecars/redhat_java_latest instead of /plugins/sidecars/redhat_java_latest

Che version

  • latest 7.2

Steps to reproduce

Create a workspace, toggle the "ephemeral mode" toggle on the overview page, and start it.

Expected behavior

Plugins volume is mounted with a subpath.
@amisevsk amisevsk added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 2, 2019
@amisevsk
Copy link
Contributor Author

amisevsk commented Oct 2, 2019

This is a blocker for rolling Che 7.2 out to production.

@amisevsk amisevsk mentioned this issue Oct 2, 2019
Merged
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 2, 2019
@benoitf benoitf added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 2, 2019
@benoitf
Copy link
Contributor

benoitf commented Oct 2, 2019

@amisevsk what is the team that is handling the workspace mounts part ? osio or platform ?
to make assignee

@amisevsk amisevsk mentioned this issue Oct 2, 2019
Closed
@amisevsk amisevsk changed the title Ephemeral workspaces cannot load plugins [regression] Ephemeral workspaces cannot load plugins Oct 2, 2019
@amisevsk
Copy link
Contributor Author

amisevsk commented Oct 2, 2019

@benoitf The issue is caused by #14539 I believe, but I'm currently taking a look.

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Oct 2, 2019 •
edited
Loading

@benoitf The issue is caused by #14539 I believe, but I'm currently taking a look.

#14539 I think so too.

@l0rd
Copy link
Contributor

l0rd commented Oct 3, 2019

@amisevsk are you able work on this (without compromising the other tasks for this sprint)?

@amisevsk amisevsk mentioned this issue Oct 3, 2019
Merged
@amisevsk
Copy link
Contributor Author

amisevsk commented Oct 3, 2019

@l0rd PR open: #14768

@amisevsk amisevsk added this to the 7.3.0 milestone Oct 4, 2019
@amisevsk amisevsk mentioned this issue Oct 7, 2019
Closed
@amisevsk
Copy link
Contributor Author

amisevsk commented Oct 7, 2019

Fix available in master.

@amisevsk amisevsk closed this as completed Oct 7, 2019
@dmytro-ndp dmytro-ndp mentioned this issue Nov 5, 2019
Closed
@dmytro-ndp
Copy link
Contributor

The issue wasn't reproduced on Single Che 7.4.0 RC installed on minikube.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amisevsk amisevsk

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Milestone
7.3.0
Development

No branches or pull requests
6 participants
@benoitf @l0rd @dmytro-ndp @AndrienkoAleksandr @amisevsk @che-bot