Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support volumes for plugin components in devfile #14634

Closed
svor opened this issue Sep 23, 2019 · 7 comments
Closed

Support volumes for plugin components in devfile #14634

svor opened this issue Sep 23, 2019 · 7 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@svor
Copy link
Contributor

svor commented Sep 23, 2019

Description

It is necessary to add an ability to set volumes for chePlugin component. For example it is needed to mount the .m2 volume to the java plugin.

@svor svor added kind/enhancement A feature request - must adhere to the feature request template. team/platform labels Sep 23, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 23, 2019
@svor
Copy link
Contributor Author

svor commented Sep 23, 2019

It is needed for #13603

@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 23, 2019
@skabashnyuk
Copy link
Contributor

@svor what are the reason not to specify m2 volume in chePlugin in plugin registry?

@skabashnyuk skabashnyuk added this to the 7.4.0 milestone Sep 24, 2019
@svor
Copy link
Contributor Author

svor commented Sep 24, 2019

@skabashnyuk as for me devfile is better place to do that, where we can see whole configuration of workspace's containers and make changes in one place.

@skabashnyuk
Copy link
Contributor

@skabashnyuk as for me devfile is better place to do that, where we can see whole configuration of workspace's containers and make changes in one place.

Apart from that, any other reasons?

CC @l0rd

@amisevsk
Copy link
Contributor

Related: PRs #14539 and eclipse-che/che-plugin-broker#74 are working on adding volumes to plugin meta.yamls for issue #13387.

@sleshchenko
Copy link
Member

Actually, volumes are already implemented for meta.yaml https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/eclipse/che-theia/next/meta.yaml#L59. And Oleksandr just works on ephemeral workspaces which are needed for another task.
So, @svor I think from maven plugin point of view it makes more sense to define it on meta.yaml level and then:

  1. every user should not define it in each of their devfile.
  2. I assume maven plugin expects maven volume in the exact path, it does not value that user should care about.

As about supporting volumes for plugin components - maybe it makes sense but at this stage we don't have any real-world purposes for them, so maybe we should delay this issue until we see any needs in it.

@metlos
Copy link
Contributor

metlos commented Nov 6, 2019

Closing as duplicate of #13318.

@metlos metlos closed this as completed Nov 6, 2019
@skabashnyuk skabashnyuk removed this from the Backlog - Platform milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

8 participants