Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider running dependency check as an action rather than integrated in the maven build #262

Open
netomi opened this issue Nov 1, 2023 · 4 comments

Comments

@netomi
Copy link
Contributor

netomi commented Nov 1, 2023

The dependency check is rather slow as it downloads all cve everytime it is run.

Consider using an action instead that comes with a pre-build image of cve's so that not all of them have to be downloaded again and again.

@mbarbero
Copy link
Member

mbarbero commented Nov 2, 2023

Agreed. Also, with proper dependabot config and dependency graph feeding, dependency-check is less useful. I've configured dependency-check here more to get a feeling about what it could provide.

@netomi
Copy link
Contributor Author

netomi commented Nov 20, 2023

In PR #274 I have moved the dependency check to a separate profile that is not enabled by default in the ci builds.

@mbarbero
Copy link
Member

Should we close this one then? Or do you want to create a workflow that will run with this profile separately?

@netomi
Copy link
Contributor Author

netomi commented Nov 20, 2023

We should add an action to run the dependency check on a regular basis using a schedule and then we can compare the results with dependabot. I see that as experimenting with existing tools to understand their strengths and weaknesses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants