Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't generate React Component Class #135

Open
mcavaliere opened this issue Dec 27, 2019 · 2 comments
Open

Can't generate React Component Class #135

mcavaliere opened this issue Dec 27, 2019 · 2 comments
Labels
chore Maintenance tasks

Comments

@mcavaliere
Copy link

in the yarn g:component hygen command, choosing Class instead of SFC still outputs a functional component.
@cball
Copy link
Member

cball commented Aug 7, 2020

I think we should remove class as an option. AFAIK there should be very few cases (if any) that we'd need a class over a functional component.

@cball cball added chore Maintenance tasks question Further information is requested labels Aug 7, 2020
@mcavaliere
Copy link
Author

@cball agree.

@cball cball removed the question Further information is requested label Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Maintenance tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cball @mcavaliere