Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): ask for database information #39

Merged
merged 1 commit into from
Aug 25, 2020
Merged

feat(cli): ask for database information #39

merged 1 commit into from
Aug 25, 2020

Conversation

cball
Copy link
Member

@cball cball commented Aug 25, 2020

This prompts the user for database info rather than us assuming.

Changes

  • update prisma .env
  • update jest.setup
  • update .env.local
  • update .env.test

Screenshots

image

Checklist

  • Requires dependency update?
  • Generating a new app works

Fixes #36

## Merge #38 first

@cball cball requested a review from a team August 25, 2020 12:02
README.md Outdated

# FAQ
If you're building a new app, your team is tackling a hard problem, or you just need help getting over the finish line, we'd love to work with you. [Say hello](https://echobind.com/contact) and tell us what you're working on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

index.js Outdated
@@ -167,6 +201,7 @@ module.exports = (name) => {
await index.addAll(".");
await index.write();
const id = await index.writeTree();
await nodegit.Remote.create(repo, "origin", variables.githubRepo);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cball cball force-pushed the 36-database-url-cli branch from 2375009 to 663f3ab Compare August 25, 2020 18:16
@cball cball force-pushed the 36-database-url-cli branch from 663f3ab to ca89c0f Compare August 25, 2020 18:19
@cball cball merged commit ef2e47a into next Aug 25, 2020
@cball cball deleted the 36-database-url-cli branch August 25, 2020 18:20
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Issue has been included in a PR label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @next released Issue has been included in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants