feat: migrate away from prisma-nexus-plugin. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthomps4
requested changes
May 11, 2021
| // List <%= plural %> Query | ||
| t.list.field('<%= plural.toLowerCase() %>', { | ||
| type: '<%= camelized %>', | ||
| authorize: () => false, |
There was a problem hiding this comment.
Is this defaulting to no authorization needed? or opposite?
If so, should we default a user context as most should/will be?
There was a problem hiding this comment.
👍 good call. I'll update. More than anything we just want to ensure to lock down by default with the generators. This is perhaps too locked down 😄
Comment on lines
+10
to
+25
| export const StringFilter = inputObjectType({ | ||
| name: 'StringFilter', | ||
| description: 'A way to filter string fields. Meant to pass to prisma where clause', | ||
| definition(t) { | ||
| t.string('contains'); | ||
| t.string('endsWith'); | ||
| t.string('equals'); | ||
| t.string('gt'); | ||
| t.string('gte'); | ||
| t.list.nonNull.string('in'); | ||
| t.string('lt'); | ||
| t.string('lte'); | ||
| t.list.nonNull.string('notIn'); | ||
| t.string('startsWith'); | ||
| }, | ||
| }); |
| t.nonNull.id('id'); | ||
| t.nonNull.date('createdAt'); | ||
| t.nonNull.date('updatedAt'); | ||
| t.nonNull.list.nonNull.field('roles', { type: 'Role' }); |
There was a problem hiding this comment.
Does nonNull catch empty arrays?
There was a problem hiding this comment.
This would be equivalent to [Role!]! which doesn't allow role to return null or any items within the array to be null. It should allow an empty array though.
| it("copies prisma/env with the correct contents", async () => { | ||
| const target = path.join(targetFolder, "prisma", ".env"); | ||
| it("copies env with the correct contents", async () => { | ||
| const target = path.join(targetFolder, ".env"); |
* updates generators * removes nexus-prisma-plugin dependency * updates package.json scripts * adds graphql shared module * updates user graphql module * renames and updates seed file
cball
force-pushed
the
136-remove-nexus-prisma-plugin
branch
from
36b57ed to
9089c05
Compare
mthomps4
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to plain Nexus. As a result the graphql modules will take a little more code to wire up, but its less "magical". I've replicated the sorting, ordering, and naming syntax that the plugin used to provide in order to ensure consistency.
The Prisma team is also re-writing this plugin, so I'd rather not depend on it. See graphql-nexus/nexus-plugin-prisma#1039 for more info.
Changes
Screenshots
n/a
Checklist
Fixes #136