Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A smartsign improvement #227

Closed
DmitryOtroshchenko opened this issue May 18, 2015 · 5 comments
Closed

A smartsign improvement #227

DmitryOtroshchenko opened this issue May 18, 2015 · 5 comments

Comments

@DmitryOtroshchenko
Copy link

First of all thank you for maintaining this great plugin!

I use easymotion quite heavily and one of the few issues I have with it are punctuation signs mistypes. I use smartsign option that helps a lot, however it my opinion optionally replacing all punctuation signs by some wildcard symbol may be beneficial. I would try something like this:

  • Create a new option
" This symbol will match any symbol from g:EasyMotion_smartsign_wildcard_expand_to
let g:EasyMotion_smartsign_wildcard = '.'
let g:EasyMotion_smartsign_wildcard_expand_to = '!@#$%^&*()--+_=,.<>/?\'"|'
  • With this example configuration searching (using easymotion) for two symbols a. will match: a., a:, a(, etc.
  • May be even create a global wildcard that matches any symbol

Do you think that this feature is "implementable" and that it will play nice with the other easymotion features?

Thank you.

@haya14busa
Copy link
Member

Thanks for the request @DmitryOtroshchenko :)
I guess this issue is related with, or same as #135

#135 feature also supports two symbols like a.

It's implementable and useful but I have not merged the feature branch into master for some bug and lack of test.

I'll work on it later as soon as possible. Thanks 👍

@DmitryOtroshchenko
Copy link
Author

Thank you for your response. I've taken a look on the tests code and it looks pretty user-friendly. Can I help with testing / writing tests? And btw what was this bug?

@haya14busa
Copy link
Member

Can I help with testing / writing tests?

If you want to write tests or test cases, I really appreciate it.

EasyMotion currently use kana/vim-vspec for testing framework but
I use thinca/vim-themis these days for test other my plugins, so
I may write test with vim-themis. I appreciate some test cases ,just using this feature, or some opnion on this :)

Opnion like this #135 (comment) or your thought on this feature.

And btw what was this bug?

Hmm... sorry I forgot the bug detail but as far as I remember, it doesn't handle well with some regular expression.

@DmitryOtroshchenko
Copy link
Author

I like the configuration template provided in #135 (comment). I will try to write some tests for it.

@haya14busa
Copy link
Member

I'll close this issue because it's almost same as #135.
Please discuss it in #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants