Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easymotion ignores code-folding #178

Closed
alexandnpu opened this issue Sep 3, 2014 · 8 comments
Closed

easymotion ignores code-folding #178

alexandnpu opened this issue Sep 3, 2014 · 8 comments

Comments

@alexandnpu
Copy link

When folding is used, the column mode does not take the folding line into account.

@haya14busa
Copy link
Member

When folding is used, the column mode does not take the folding line into account.

Thank you for the report.
But, what is the column mode? You meant <Plug>(easymotion-j) and <Plug>(easymotion-k)?

@haya14busa haya14busa reopened this Sep 3, 2014
@alexandnpu
Copy link
Author

yes,, that is what I mean.

@haya14busa
Copy link
Member

Ok, I got it.

Actually, the highlight for folded column's priority is always higher than user defined highlights, so
easymotion cannot handle folded line correctly and skip them by intention.

However, if you doesn't care highlight, there is undocumented option not to skip them.

Please write following line into your vimrc.

let g:EasyMotion_skipfoldedline = 0

@alexandnpu
Copy link
Author

Thanks for your advice. I tried that option, and it looks like the following:
image

as you can see, the line indicator does not show at the very beginning of the line and does not have color. Will this be enhanced?

I don't quite understand your saying about highlight priority. Could you explain more?
I know little about the vim script language or programming.

@haya14busa
Copy link
Member

the line indicator does not show at the very beginning of the line

The folded text is determined by :h foldtext(), so as far as I know, it cannot
be enhanced anymore or it's so hard to implement at least.

and does not have color

I mean the cause of this problem is the highlight priority I mentioned above.

@haya14busa
Copy link
Member

It seems highlight for fold cannot be overwritten, so it's impossible to fix it. close

@haya14busa
Copy link
Member

#44

@draftman9
Copy link

Thanks for your advice. I tried that option, and it looks like the following: image

as you can see, the line indicator does not show at the very beginning of the line and does not have color. Will this be enhanced?

It seems highlight for fold cannot be overwritten, so it's impossible to fix it. close

For easymotion-jk motion, I have an idea inspired by the semantic checking of some LSP. That is we may place the icon of target like "s" on the the place of "3" which originally is the line number, which can be seen from the quoting picture. I see that the place of line number can be replaced by Error sign and Warning sign and so on. So I think it may also be replaced by the signs of easymotion icons of targets.

And I think it is appropriate to place the icons of targets on the places of line numbers for the easymotion-jk motion aka line jump motions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants