-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EasyList Dutch needs an update: it's very outdated #11
Conversation
Deleting from outdated rules and adding new ones.
Adding new rules.
Deleting outdated rules and adding new ones.
Adding new rule: should be blocked.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
Deleting outdated rules and adding new ones.
@JohnyP36 Thanks for your contributions! As these are quite a lot of changes at once, please make sure your changes meet ABP requirements. Most importantly anti-adblock shouldn't be tackled in this list (as it is illegal in some countries) and tracking filters should go into EasyPrivacy instead. |
delete "icttipsandtricks.nl##+js(acis, jQuery, ai_adb)" and "nu.nl##+js(set, is_adblocker_in_use, false)" , because does ruled not meed ABP standards.
@monzta There where already anti-adblock rules in this list; I only changed them. (In the Netherlands anti-adblock isn't illegal and thus such rules could be added in EL Dutch. I live in the Netherlands) |
To be clear as crystal: EasyList Dutch already contained anti-adblock rules. As this list is only for Dutch domains and in the Netherlands (and Belgium) anti-adblock rules aren't illegal. |
These are the requirements for ABP. Also old anti-adblock rules shouldn't be updated. Your PR also still contains tracking ffilters (e.g. |
If I remove the anti-adblock rules some parts or the complete site wouldn't work at all or not properly. But as you wish: I will remove those rules. |
@monzta I think I did all you want. @BPower0036 could check if there are no tracking filters in those lists? I think I removed them. |
Sorry for the delay! I think these rules belong to EasyPrivacy:
ABP doesn't supprt |
EasyList Dutch has many rules for domains that don't exist anymore. Also sites has changed so old rules should be deleted and new ones added.