Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLens Requires an unmaintained version of git for OSX #55

Closed
joshwiens opened this issue Mar 27, 2017 · 10 comments
Closed

GitLens Requires an unmaintained version of git for OSX #55

joshwiens opened this issue Mar 27, 2017 · 10 comments

Comments

@joshwiens
Copy link

More of a note from one project maintainer to another.

The latest version of gitlens ( which i love btw ) requires a version of Git that isn't available on OSX via the standalone installer which means OSX users will either have to install git from src or use something like homebrew.

While I personally don't have an issue with either one of those options, a lot of people either aren't going to want to mess with their local git install or simply won't be able to because of a lack of system level knowledge or limited access in IT controlled systems.

Something to consider for the future.

@obrejla
Copy link

obrejla commented Mar 27, 2017

Exactly. Please, remove that check and support just maintained 2.10.1 version ;) Thanks!

@joshwiens
Copy link
Author

From what I can see, that ship has sailed already. Only viable options are to lock to the previous version, disable the plugin, or use something like brew to install a more up to date version of git and then go update your path and deal with xcodes config.

@mikes-gh
Copy link

OSX and windows user here

I am interested to know what bits of gitlens rely on the changes between 2.10.1 and 2.11.1
A better message might be info "xyz features of git lens require 2.11.1. Please upgrade to >= 2.11.1 if you require these features" Dont Show Again|OK

Great extension BTW thanks.

@guidsdo
Copy link

guidsdo commented Mar 27, 2017

Same as for Fedora! Fedora only comes with git version 2.9.3. This version is stable and I don't see why a higher version should be required tbh. Please downgrade, since I really want to use codelens in my companies big project.

@josser
Copy link

josser commented Mar 27, 2017

Same for Ubuntu.
As you can see http://packages.ubuntu.com/search?suite=all&searchon=names&keywords=git
Even on latest zesty only 2.11.0 is available for install.

@eamodio
Copy link
Member

eamodio commented Mar 27, 2017

Sorry about this -- I didn't realize I had taken a dependency on a later version of Git until I has already released v3. I believe the only case that requires v2.11.0 of Git is my use of the git status --porcelain=v2, so I will be looking to put a fallback in place if there is a older version of Git. Once that is in, I will also remove the Git version warning and put it back to the prior version.

I'm terribly sorry about the inconvenience.

@eamodio
Copy link
Member

eamodio commented Mar 27, 2017

I've added a fallback in v3.0.3 to not require git >= 2.11.0, so the requirement should be back to >= 2.2.0 -- again really sorry for this :(

@joshwiens
Copy link
Author

It's all good... Stuff happens. Thanks for the quick turn around :)

@mikes-gh
Copy link

Thanks for quick turnaround

billsedison added a commit to noside911/vscode-gitlens that referenced this issue Jan 4, 2019
Closes gitkraken#53: Commits list electron app enhancement gitkraken#53
@github-actions
Copy link

github-actions bot commented Dec 9, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants