Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS errors on welcome page (mask-* properties) #288

Closed
dipnlik opened this issue Feb 14, 2018 · 2 comments
Closed

CSS errors on welcome page (mask-* properties) #288

dipnlik opened this issue Feb 14, 2018 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dipnlik
Copy link

dipnlik commented Feb 14, 2018

  • GitLens Version: 8.0.0
  • VSCode Version: 1.20.0
  • OS Version: Ubuntu 17.10

Steps to Reproduce:

  1. Ctrl-Shift-P, GitLens: Welcome.
  2. Look at these 5 Problems in the status bar.

file: 'file:///home/dipnlik/.vscode/extensions/eamodio.gitlens-8.0.0/welcome.html'
severity: 'Warning'
message: 'Unknown property: 'mask-image''
at: '1,3972'
source: 'css'
code: 'unknownProperties'

file: 'file:///home/dipnlik/.vscode/extensions/eamodio.gitlens-8.0.0/welcome.html'
severity: 'Warning'
message: 'Unknown property: 'mask-repeat''
at: '1,4626'
source: 'css'
code: 'unknownProperties'

file: 'file:///home/dipnlik/.vscode/extensions/eamodio.gitlens-8.0.0/welcome.html'
severity: 'Warning'
message: 'Unknown property: 'mask-image''
at: '1,6598'
source: 'css'
code: 'unknownProperties'

file: 'file:///home/dipnlik/.vscode/extensions/eamodio.gitlens-8.0.0/welcome.html'
severity: 'Warning'
message: 'Unknown property: 'mask-size''
at: '1,7026'
source: 'css'
code: 'unknownProperties'

file: 'file:///home/dipnlik/.vscode/extensions/eamodio.gitlens-8.0.0/welcome.html'
severity: 'Warning'
message: 'Unknown property: 'mask-repeat''
at: '1,7074'
source: 'css'
code: 'unknownProperties'


I don't know what's the expected behavior of these CSS properties in the page but the page doesn't look "broken" and having problems pop up in the status bar looks bad, so maybe these properties can be safely removed?

@eamodio
Copy link
Member

eamodio commented Feb 14, 2018

I can remove those unprefixed versions for now (they were added as future-proofing) as this is not noise I want to expose users to, but I also opened microsoft/vscode#43678

@eamodio eamodio self-assigned this Feb 14, 2018
@eamodio eamodio added the bug Something isn't working label Feb 14, 2018
@eamodio eamodio added this to the Soon™ milestone Feb 14, 2018
@eamodio eamodio removed this from the Soon™ milestone Jul 19, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants