From 6fdb73a5600bb1e4602df4b1c0a0ea914c3107eb Mon Sep 17 00:00:00 2001 From: eacaps Date: Thu, 21 Jul 2016 16:35:42 -0400 Subject: [PATCH] cleaned up rubocop warnings --- app/helpers/react_on_rails_helper.rb | 1 + spec/dummy/app/mailers/dummy_mailer.rb | 6 +++--- spec/dummy/config/initializers/react_on_rails.rb | 1 + spec/dummy/spec/requests/server_render_check_spec.rb | 6 +++--- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/app/helpers/react_on_rails_helper.rb b/app/helpers/react_on_rails_helper.rb index 6cc6896db..b9d6e5038 100644 --- a/app/helpers/react_on_rails_helper.rb +++ b/app/helpers/react_on_rails_helper.rb @@ -341,6 +341,7 @@ def initialize_redux_stores # This is the definitive list of the default values used for the rails_context, which is the # second parameter passed to both component and store generator functions. + # rubocop:disable Metrics/AbcSize def rails_context(server_side:) @rails_context ||= begin result = {} diff --git a/spec/dummy/app/mailers/dummy_mailer.rb b/spec/dummy/app/mailers/dummy_mailer.rb index b8df25a99..c1404e95a 100644 --- a/spec/dummy/app/mailers/dummy_mailer.rb +++ b/spec/dummy/app/mailers/dummy_mailer.rb @@ -1,9 +1,9 @@ class DummyMailer < ActionMailer::Base add_template_helper(ReactOnRailsHelper) - default from: 'nobody@nope.com' + default from: "nobody@nope.com" # layout 'mailer' def hello_email - mail(to: 'otherperson@nope.com', subject: "you've got mail") + mail(to: "otherperson@nope.com", subject: "you've got mail") end -end \ No newline at end of file +end diff --git a/spec/dummy/config/initializers/react_on_rails.rb b/spec/dummy/config/initializers/react_on_rails.rb index 57d681e6e..466dea1e5 100644 --- a/spec/dummy/config/initializers/react_on_rails.rb +++ b/spec/dummy/config/initializers/react_on_rails.rb @@ -8,6 +8,7 @@ def self.custom_context(view_context) somethingUseful: view_context.session[:something_useful] } rescue + result = {} end result end diff --git a/spec/dummy/spec/requests/server_render_check_spec.rb b/spec/dummy/spec/requests/server_render_check_spec.rb index b2ddf75db..b36aa3c47 100644 --- a/spec/dummy/spec/requests/server_render_check_spec.rb +++ b/spec/dummy/spec/requests/server_render_check_spec.rb @@ -59,10 +59,10 @@ end describe "server render mailer" do - it 'sends email okay' do + it "sends email okay" do mail = DummyMailer.hello_email - expect(mail.subject).to match 'mail' - expect(mail.body).to match 'Mr. Mailing Server Side Rendering' + expect(mail.subject).to match "mail" + expect(mail.body).to match "Mr. Mailing Server Side Rendering" end end