New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function "toLowerCase" not called, impossible to insert a canvas directly #699

Closed

ThibautSembeni opened this issue Jun 28, 2024 · 1 comment · Fixed by #701

ThibautSembeni commented Jun 28, 2024

html2pdf.js/src/worker.js

Line 64 in f6ac182

    
           case 'element': return src.nodeName.toLowerCase === 'canvas' ? 'canvas' : 'element';

Really ?

Owner

eKoopmans commented Jun 30, 2024

Lol yeah that looks bad, thanks. This project's been in a "good enough" state for a while but it definitely needs some work.

eKoopmans mentioned this issue

fix: Using canvas as a direct source #701

Merged

eKoopmans closed this as completed in #701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment