Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel-dialog: scrollbar during the opening animation #2601

Open
1 task done
jpokropinskieb opened this issue Mar 14, 2025 · 0 comments · May be fixed by #2599
Open
1 task done

panel-dialog: scrollbar during the opening animation #2601

jpokropinskieb opened this issue Mar 14, 2025 · 0 comments · May be fixed by #2599

Comments

@jpokropinskieb
Copy link

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

When panel-dialog or dropdown-dialog are opened a scrollbar on whole site height/width appears during the animation.

Expected behavior

No scrollbar

Skin version

No response

Device/OS/Browser info

Mac OS desktop, Chrome

Steps to reproduce

1. Visit page with a dialog (eg. https://www.ebay.com/ebaylive/channels/2Nk3OYiOJHfXqpWG)
2. Open the dialog (press the "i" icon)

Relevant code block

src/sass/mixins/private/_dialog-mixins.scss

@mixin dialog-base() {
    background-color: var(--dialog-scrim-color-show);
    bottom: 0;
    left: 0;
    -webkit-overflow-scrolling: touch;
    overflow-y: auto;
    position: fixed;
    right: 0;
    top: 0;
    will-change: background-color;
    z-index: 100000; /* because global header has an element with 99999 */

    &:not([hidden]) {
        display: flex;
    }
}

Additional context

Screen.Recording.2025-03-13.at.08.56.49.mov
Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant