-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
230810 - Item tile framework and components #2133
Comments
Need to verify if we can use grid layout to align the title and price elements. |
I verified that The solution will involve something along the lines of: grid-template-rows: auto 25px 60px 1fr;
grid-template-areas:
"image"
"signal"
"title"
"highlight"; |
@ratinsl , I'm punting this for now. The DS specs are not feasible in some instances and they generally need to be more responsive-centric and less pixel-prescriptive. We can discuss offline. |
Hey, @ratinsl , to start this issue, we'll need the number of item tiles to display per row before wrapping to next line. Once those specs are defined, we can start this. This is related to the discussion we had previously about responsive elements that repeat. The minimum and maximum widths of the item tiles should also not block the item tiles from being fluid enough with the rules you put in place. |
I'm assuming we can update the specs to match the toggle button. I can try helping there. |
Thanks, @randybascue . Yes, it would be similar to what you did with |
Ideally, before doing this or alongside this issue, it would be great to abstract the responsive group items/row handling into an abstract module (initially used in |
Deprioritized for now. Suggested to bring in the seller team to understand use case. |
@ArtBlue updated all of the documentation on Playbook to reflect what was asked above. Let me know if there is anything else that needs to be expanded on. |
@ArtBlue here are the figma files: Component in FIgma (I think this is the only one you'll need) |
@ratinsl , I'm posting the questions/clarifications I need here for better transparency. Here are some of the things (so far) I need clarifications on:
Also, as previously briefly discussed, some of the more eBay proprietary sections will need to be made more generalized. The internals that need to be more specific in terms of custom styling/spacing will need to be built in Business Components. This includes sections, such as price, for example. |
|
All item tile documentation has been updated on Playbook:
https://playbook.ebay.com/design-system/components/item-tile
Please reach out to Jeremy and I with any questions.
Best,
Ryan
The text was updated successfully, but these errors were encountered: