Skip to content

Commit 5b7bf40

Browse files
ci: release (#2353)
1 parent de10cf5 commit 5b7bf40

File tree

140 files changed

+900
-413
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

140 files changed

+900
-413
lines changed

.changeset/curvy-bobcats-attend.md

-5
This file was deleted.

.changeset/four-mangos-hug.md

-5
This file was deleted.

.changeset/purple-seals-deliver.md

-5
This file was deleted.

.changeset/strong-grapes-work.md

-5
This file was deleted.

CHANGELOG.md

+12
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11
# eBayUI-Core Changelog
22

3+
## 14.6.0
4+
5+
### Minor Changes
6+
7+
- [#2351](https://github.com/eBay/ebayui-core/pull/2351) [`8024cfe`](https://github.com/eBay/ebayui-core/commit/8024cfe2a7db3c6e21c0fbbe1edda25198358694) Thanks [@LuLaValva](https://github.com/LuLaValva)! - feat(eek): added size option
8+
9+
- [#2348](https://github.com/eBay/ebayui-core/pull/2348) [`981e76a`](https://github.com/eBay/ebayui-core/commit/981e76ac2d00d961a552a59dfa3914b3f1148516) Thanks [@saiponnada](https://github.com/saiponnada)! - docs(contributing): updated tests section
10+
11+
- [#2337](https://github.com/eBay/ebayui-core/pull/2337) [`9c308b4`](https://github.com/eBay/ebayui-core/commit/9c308b46736f2ac646cec07d4e92f2ada1a10954) Thanks [@agliga](https://github.com/agliga)! - feat: added async loading instead of cdn loader
12+
13+
- [#2352](https://github.com/eBay/ebayui-core/pull/2352) [`a5b2e69`](https://github.com/eBay/ebayui-core/commit/a5b2e6967a53593a2766f651ebed89328b7e093f) Thanks [@WinkeeFace](https://github.com/WinkeeFace)! - fix(ebay-carousel): fix width calculation for last pill when font not loaded (#2344)
14+
315
## 14.5.1
416

517
### Patch Changes

CONTRIBUTING.md

+41-41
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@ This page contains instructions and guidelines for anybody contributing code to
44

55
## Table of Contents
66

7-
- [Development](#development)
8-
- [Pull Requests](#pull-requests)
9-
- [Branching Strategy](#branching-strategy)
10-
- [Unit Tests](#unit-tests)
11-
- [Definition of Done](#definition-of-done)
12-
- [Naming Scheme](#naming-scheme)
13-
- [Releases](#releases)
7+
- [Development](#development)
8+
- [Pull Requests](#pull-requests)
9+
- [Branching Strategy](#branching-strategy)
10+
- [Unit Tests](#unit-tests)
11+
- [Definition of Done](#definition-of-done)
12+
- [Naming Scheme](#naming-scheme)
13+
- [Releases](#releases)
1414

1515
## Development
1616

1717
This section includes information on system requirements, running the local server, tests and package scripts.
1818

1919
### System Requirements
2020

21-
- [Node.js](https://nodejs.org/en/)
21+
- [Node.js](https://nodejs.org/en/)
2222

2323
Clone this repo to your local environment then run `npm i` to install all dependencies.
2424

@@ -71,20 +71,20 @@ If you are creating a new component or significantly altering an existing one, p
7171

7272
We ask this because:
7373

74-
- we want to avoid cases where developers build something that does not align with our wants & needs
75-
- we want to be able to carefully plan our sprint and test cycles with minimal disruption
76-
- we want to avoid cases where two developers duplicate work
74+
- we want to avoid cases where developers build something that does not align with our wants & needs
75+
- we want to be able to carefully plan our sprint and test cycles with minimal disruption
76+
- we want to avoid cases where two developers duplicate work
7777

7878
### Writing Code
7979

8080
The contents of a pull request should be related to a single issue only (or, at most, perhaps two very closely related issues). The reviewer has the right to reject a pull request that contains anything non-issue related.
8181

8282
Whilst it may be tempting to fix any [broken windows](https://www.rtuin.nl/2012/08/software-development-and-the-broken-windows-theory/) that you encounter, we ask you not to because:
8383

84-
- it can distract the reviewer from the main issue at hand
85-
- it can add additional time needed for the reviewer
86-
- it can increase the chance of regressions
87-
- it can make rollbacks more difficult
84+
- it can distract the reviewer from the main issue at hand
85+
- it can add additional time needed for the reviewer
86+
- it can increase the chance of regressions
87+
- it can make rollbacks more difficult
8888

8989
So please be a good citizen and create separate issues or pull requests for any broken windows that you find.
9090

@@ -159,10 +159,10 @@ A milestone branch will be deleted after it has been merged into master. There i
159159

160160
With this strategy, there are rarely more than a handful of branches at any one moment in time:
161161

162-
- master branch (reflects current production code/release)
163-
- next minor or major milestone branch
164-
- next patch milestone branch
165-
- _n_ number of feature/issue branches (usually 1 - 3)
162+
- master branch (reflects current production code/release)
163+
- next minor or major milestone branch
164+
- next patch milestone branch
165+
- _n_ number of feature/issue branches (usually 1 - 3)
166166

167167
## Unit Tests
168168

@@ -176,12 +176,12 @@ Browser side testing is predominantly concerned with the testing of _state_. For
176176

177177
For both types of tests, please observe the following golden rules:
178178

179-
- A test should only test one thing
180-
- Watch out for the words 'and' & 'or' in your test description!
181-
- A test should not contain conditional logic
182-
- We don't want to have to write tests for our tests!
183-
- A test description should avoid interpolated strings
184-
- Test descriptions should be human readable (readable != parsable)
179+
- A test should only test one thing
180+
- Watch out for the words 'and' & 'or' in your test description!
181+
- A test should not contain conditional logic
182+
- We don't want to have to write tests for our tests!
183+
- A test description should avoid interpolated strings
184+
- Test descriptions should be human readable (readable != parsable)
185185

186186
Above all, all aspects of a test should be human readable. A simple litmus test for this is that anybody should be able to read the test and, within a few seconds, be able to tell you what the _purpose_ of the test is. If they are confused, or ask questions, then it is not a well written test. Go back and refactor!
187187

@@ -191,28 +191,28 @@ A component is considered "done", and ready for merge into release branch, when
191191

192192
1. Foundational layer review
193193

194-
- Visual design (DS6)
195-
- Markup structure (Bones)
196-
- Accessibility pattern (MIND)
197-
- CSS (Skin)
194+
- Visual design (DS6)
195+
- Markup structure (Bones)
196+
- Accessibility pattern (MIND)
197+
- CSS (Skin)
198198

199199
2. Component layer review
200200

201-
- Tag API
202-
- Event API
203-
- Unit tests
204-
- Integration test
205-
- Performance test
206-
- Documentation
201+
- Tag API
202+
- Event API
203+
- Unit tests
204+
- Integration test
205+
- Performance test
206+
- Documentation
207207

208208
3. Code review
209209

210-
- Linter should catch syntax and style issues
211-
- Prefer performance over readability, but readability over "space saving" code
212-
- Apply the single-responsibility principle to functions
213-
- Refactor long functions into several small functions
214-
- Identify and move common utility functions to libraries or static methods
215-
- All CSS should come from Skin
210+
- Linter should catch syntax and style issues
211+
- Prefer performance over readability, but readability over "space saving" code
212+
- Apply the single-responsibility principle to functions
213+
- Refactor long functions into several small functions
214+
- Identify and move common utility functions to libraries or static methods
215+
- All CSS should come from Skin
216216

217217
## Naming Scheme
218218

0 commit comments

Comments
 (0)