Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Comments without ajax issue #5111

Closed
Jimmi08 opened this issue Nov 22, 2023 · 0 comments
Closed

[Bug]: Comments without ajax issue #5111

Jimmi08 opened this issue Nov 22, 2023 · 0 comments
Labels
type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Nov 22, 2023

What e107 version are you using?

Latest Github version (just updated)

Bug description

This is just a note for anybody who can test it.

When you use comments without ajax (from any reason, in my case temp test in WordPress environment), comments are not saved in PHP 8 and the reason is this:

image

It failed in PHP 8 because this variable wasn't set.

How to reproduce

Use comments without Ajax.

I am aware that this is hard to reproduce and I will extend this issue if I have time for this.

The problem is deeper and I just wanted to save what I found. Adding this line
$comment_share = 0; //BC Fix.
fixed issue and comment was saved.

Expected behavior

Working comment system without AJAX. Ajax is fine but as soon as your site produces any error, it is not working.

What browser(s) are you seeing the problem on?

Chrome / Brave

PHP Version

8.1

@Jimmi08 Jimmi08 added the type: bug A problem that should not be happening label Nov 22, 2023
@CaMer0n CaMer0n added this to the e107 2.3.3 milestone Nov 22, 2023
@CaMer0n CaMer0n changed the title [Bug]: comments without ajax issue [Bug]: Comments without ajax issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

2 participants