diff --git a/docs/itest.md b/docs/itest.md
index 2819f20..0ece3d1 100644
--- a/docs/itest.md
+++ b/docs/itest.md
@@ -33,6 +33,8 @@ itest_service(name, health_check_args | Arguments to pass to the health_check binary. The various defined ports will be substituted prior to being given to the health_check binary. | List of strings | optional | []
|
| health_check_interval | The duration between each health check. The syntax is based on common time duration with a number, followed by the time unit. For example, 200ms
, 1s
, 2m
, 3h
, 4d
. | String | optional | "200ms"
|
| health_check_timeout | The timeout to wait for the health check. The syntax is based on common time duration with a number, followed by the time unit. For example, 200ms
, 1s
, 2m
, 3h
, 4d
. If empty or not set, the health check will not have a timeout. | String | optional | ""
|
-| hot_reloadable | If set to True, the service manager will propagate ibazel's reload notificaiton over stdin instead of restarting the service. See the ruleset docstring for more info on using ibazel | Boolean | optional | False
|
+| hot_reloadable | If set to True, the service manager will propagate ibazel's reload notification over stdin instead of restarting the service. See the ruleset docstring for more info on using ibazel | Boolean | optional | False
|
| http_health_check_address | If set, the service manager will send an HTTP request to this address to check if the service came up in a healthy state. This check will be retried until it returns a 200 HTTP code. When used in conjunction with autoassigned ports, $${@@//label/for:service:port_name}
can be used in the address. Example: http_health_check_address = "http://127.0.0.1:$${@@//label/for:service:port_name}",
| String | optional | ""
|
| named_ports | For each element of the list, the service manager will pick a free port and assign it to the service. The port's fully-qualified name is the service's fully-qualified label and the port name, separated by a colon. For example, a port assigned with names_ports = ["http_port"]
will be assigned a fully-qualified name of @@//label/for:service:http_port
.
Named ports are accessible through the service-port mapping. For more details, see autoassign_port
. | List of strings | optional | []
|
| so_reuseport_aware | If set, the service manager will not release the autoassigned port. The service binary must use SO_REUSEPORT when binding it. This reduces the possibility of port collisions when running many service_tests in parallel, or when code binds port 0 without being aware of the port assignment mechanism.
Must only be set when autoassign_port is enabled. | Boolean | optional | False
|
@@ -88,7 +90,9 @@ itest_task(name, data<
A task is a one-shot (not long-running binary) that is intended to be executed as part of the itest scenario creation.
-Examples include: filesystem setup, dynamic config file generation (especially if it depends on ports), DB migrations or seed data creation
+Examples include: filesystem setup, dynamic config file generation (especially if it depends on ports), DB migrations or seed data creation.
+
+All [common binary attributes](https://bazel.build/reference/be/common-definitions#common-attributes-binaries) are supported including `args`.
**ATTRIBUTES**
@@ -134,6 +138,8 @@ service_test(
Typically this would be wrapped into a macro.
+All [common binary attributes](https://bazel.build/reference/be/common-definitions#common-attributes-binaries) are supported including `args`.
+
**ATTRIBUTES**
diff --git a/private/itest.bzl b/private/itest.bzl
index 9625527..c99dcbf 100644
--- a/private/itest.bzl
+++ b/private/itest.bzl
@@ -229,7 +229,7 @@ _itest_service_attrs = _itest_binary_attrs | {
doc = "The timeout to wait for the health check. The syntax is based on common time duration with a number, followed by the time unit. For example, `200ms`, `1s`, `2m`, `3h`, `4d`. If empty or not set, the health check will not have a timeout.",
),
"hot_reloadable": attr.bool(
- doc = """If set to True, the service manager will propagate ibazel's reload notificaiton over stdin instead of restarting the service.
+ doc = """If set to True, the service manager will propagate ibazel's reload notification over stdin instead of restarting the service.
See the ruleset docstring for more info on using ibazel""",
),
"http_health_check_address": attr.string(
@@ -250,7 +250,9 @@ itest_service = rule(
implementation = _itest_service_impl,
attrs = _itest_service_attrs,
executable = True,
- doc = "An itest_service is a binary that is intended to run for the duration of the integration test. Examples include databases, HTTP/RPC servers, queue consumers, external service mocks, etc.",
+ doc = """An itest_service is a binary that is intended to run for the duration of the integration test. Examples include databases, HTTP/RPC servers, queue consumers, external service mocks, etc.
+
+All [common binary attributes](https://bazel.build/reference/be/common-definitions#common-attributes-binaries) are supported including `args`.""",
)
def _itest_task_impl(ctx):
@@ -263,7 +265,9 @@ itest_task = rule(
attrs = _itest_binary_attrs,
executable = True,
doc = """A task is a one-shot (not long-running binary) that is intended to be executed as part of the itest scenario creation.
-Examples include: filesystem setup, dynamic config file generation (especially if it depends on ports), DB migrations or seed data creation""",
+Examples include: filesystem setup, dynamic config file generation (especially if it depends on ports), DB migrations or seed data creation.
+
+All [common binary attributes](https://bazel.build/reference/be/common-definitions#common-attributes-binaries) are supported including `args`.""",
)
def _itest_service_group_impl(ctx):
@@ -397,7 +401,9 @@ service_test(
)
```
-Typically this would be wrapped into a macro.""",
+Typically this would be wrapped into a macro.
+
+All [common binary attributes](https://bazel.build/reference/be/common-definitions#common-attributes-binaries) are supported including `args`.""",
)
def _create_version_file(ctx, inputs):