Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Height with Dynamic Content #80

Open
vencho-mdp opened this issue Jan 10, 2022 · 8 comments
Open

Updating Height with Dynamic Content #80

vencho-mdp opened this issue Jan 10, 2022 · 8 comments

Comments

@vencho-mdp
Copy link

Hi! Me again haha. I found a bug that when you change the content inside the accordion, the height of it doesn't change, producing an overflow. Maybe you could expose the recompute height method or something like that?

@opichon
Copy link
Contributor

opichon commented Jan 11, 2022

I'll take a look at this. Thanks for reporting the issue!

@vencho-mdp
Copy link
Author

Just to clarify what I mean, given two components that have different heights, when you conditionally render one or
the other, the accordion doesn't change its height (it shows an overflow if the height of the new component is more than the height of the previous one, or it shows blank space). It'd be great if the accordion could recompute its height with maybe a smooth transition or something like that.

@vencho-mdp
Copy link
Author

@opichon Do you need any help?

@opichon
Copy link
Contributor

opichon commented Jan 15, 2022

You mean that you want to render the content of an accordion tab with 1 of 3 components. The 2 components have different heights. Is this correct?

@opichon
Copy link
Contributor

opichon commented Jan 15, 2022

Can you share the code that you use?

@vencho-mdp
Copy link
Author

vencho-mdp commented Jan 15, 2022

Nono, actually is like this.

<Accordion>
 <div v-if="isUserAuthenticated" style="height:200px;"> 200px </div>
  <div v-else style="height:300px;"> 300px </div>
</Accordion>

When isUserAuthenticated changes, there is a bug with the accordion's height.

@vencho-mdp
Copy link
Author

Hi! Have you checked this out?

@vencho-mdp
Copy link
Author

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants