Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra parameters to HTML tag and convert data tags for bootstrap_… #436

Closed
wants to merge 1 commit into from

Conversation

ralokt
Copy link

@ralokt ralokt commented May 16, 2018

…button and bootstrap_label

Implements #376

I made a possibly controversial decision when I implemented this - parameters that start with "data_" get their underscores converted to hyphens. This is because data attribute names must start with the string "data-", but anything that fits that is not a valid identifier and can't be passed from Django templates.

On the other hand, blind conversion might be a bad idea? It would, however, be more consistent.

In any case, making it consistent is a matter of simplifying the code, so I'm just going to leave it that way, and am open to changing it.

@coveralls
Copy link

coveralls commented May 16, 2018

Coverage Status

Coverage increased (+0.2%) to 85.146% when pulling 8ed9bf8 on ralokt:master into e80c739 on dyve:master.

@dyve
Copy link
Member

dyve commented Aug 18, 2019

Thanks. This would be a precedent for other functions, and I think it's too big to do in the final release(s) / stage(s) of this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants