Add extra parameters to HTML tag and convert data tags for bootstrap_… #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…button and bootstrap_label
Implements #376
I made a possibly controversial decision when I implemented this - parameters that start with
"data_"
get their underscores converted to hyphens. This is because data attribute names must start with the string"data-"
, but anything that fits that is not a valid identifier and can't be passed from Django templates.On the other hand, blind conversion might be a bad idea? It would, however, be more consistent.
In any case, making it consistent is a matter of simplifying the code, so I'm just going to leave it that way, and am open to changing it.