From 3f568ac1f9029327c0f04f05ea99715260035663 Mon Sep 17 00:00:00 2001 From: dyoshikawa Date: Mon, 8 Jun 2026 23:12:35 -0700 Subject: [PATCH] ci(e2e): drop unsupported macos-15-intel runner and set fail-fast: false The macos-15-intel (Intel macOS) E2E leg fails at the Setup mise step because mise installs pnpm via the aqua backend (aqua:pnpm/pnpm), which dropped darwin/amd64 support: "unsupported env: darwin/amd64 (supported: [linux, windows, darwin/arm64])". This is an upstream toolchain limitation outside the project's control and currently breaks E2E on main and every PR. Because the matrix used the default fail-fast: true, this single platform failure also cancelled the ubuntu/macos-latest/windows legs, masking their (passing) results. Remove the macos-15-intel leg from the matrix and add fail-fast: false so the remaining platforms always report their own status. The Unix binary-path selector's former Intel branch is now an explicit error to avoid silently testing the wrong binary if a new Unix platform is added. Trade-off: the darwin-x64 binary is still built but no longer smoke-tested natively, since GitHub-hosted Intel macOS runners can no longer bootstrap the toolchain. If Intel coverage must be retained, pnpm would need to be installed off the aqua backend (e.g. npm:pnpm in mise.toml or corepack). Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/e2e-binaries.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e-binaries.yml b/.github/workflows/e2e-binaries.yml index 184a6bb84..d375c510c 100644 --- a/.github/workflows/e2e-binaries.yml +++ b/.github/workflows/e2e-binaries.yml @@ -58,8 +58,11 @@ jobs: runs-on: ${{ matrix.os }} needs: build strategy: + # Keep every platform leg running even if one fails, so a single + # platform-specific breakage does not mask the others' results. + fail-fast: false matrix: - os: [ubuntu-latest, macos-latest, macos-15-intel, windows-latest] + os: [ubuntu-latest, macos-latest, windows-latest] steps: - name: Checkout code @@ -86,9 +89,8 @@ jobs: chmod +x dist-bun/rulesync-darwin-arm64 BINARY_PATH=dist-bun/rulesync-darwin-arm64 else - # macos-15-intel is Intel (x64) - chmod +x dist-bun/rulesync-darwin-x64 - BINARY_PATH=dist-bun/rulesync-darwin-x64 + echo "Unexpected matrix OS for Unix binary selection: $MATRIX_OS" >&2 + exit 1 fi echo "BINARY_PATH=$BINARY_PATH" >> "$GITHUB_ENV"