Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit order_id length when submitting eIBC order to avoid block spam #644

Closed
omritoptix opened this issue Mar 10, 2024 · 0 comments · Fixed by #656
Closed

Limit order_id length when submitting eIBC order to avoid block spam #644

omritoptix opened this issue Mar 10, 2024 · 0 comments · Fixed by #656
Assignees
@omritoptix
Labels
c:eibc enhancement New feature or request

Comments

@omritoptix
Copy link
Contributor

check should be added in ValidateBasic of the MsgFulfillOrder
@omritoptix omritoptix added enhancement New feature or request c:eibc labels Mar 10, 2024
@omritoptix omritoptix changed the title Limit order_id when submitting eIBC order to avoid block spam Limit order_id length when submitting eIBC order to avoid block spam Mar 10, 2024
@omritoptix omritoptix self-assigned this Mar 10, 2024
@omritoptix omritoptix linked a pull request Mar 12, 2024 that will close this issue
fix: add validation on demand order id max length #656
Merged
29 tasks
@zale144 zale144 mentioned this issue Apr 2, 2024
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omritoptix omritoptix

Labels
c:eibc enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add validation on demand order id max length dymensionxyz/dymension
1 participant
@omritoptix