Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sponsorship): module scaffolding #994

Merged
merged 13 commits into from
Aug 5, 2024
Merged

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Jul 15, 2024

Description

This PR adds draft x/sponsorship implementation which contains:

  • AppModule
  • Validation and unit tests for module types
  • CLI commands
  • Draft module keeper
  • State operations for the distribution, votes, and module params

UPD 29.07.2024:

  • Updated proto contracts
  • Resolved threads
  • Deleted MsgUpdateParams

Part of #983

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md <-- will add after the module scaffolding
  • Targeted PR against the correct branch
  • Included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist <-- SDK is not used in this PR

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch self-assigned this Jul 15, 2024
@keruch keruch force-pushed the kirill/sponsorship-proto branch from 495c334 to 85eb92d Compare July 17, 2024 17:11
@keruch keruch force-pushed the kirill/sponsorship-module branch from a2d04f5 to 8867d60 Compare July 17, 2024 17:12
@keruch keruch added the c:sponsorship x/sponsorship module label Jul 17, 2024
@keruch keruch requested review from spoo-bar and mtsitrin July 17, 2024 18:32
@keruch keruch marked this pull request as ready for review July 17, 2024 18:32
@keruch keruch requested a review from a team as a code owner July 17, 2024 18:32
Base automatically changed from kirill/sponsorship-proto to main July 17, 2024 19:42
@keruch keruch force-pushed the kirill/sponsorship-module branch 2 times, most recently from 40400a0 to fae1563 Compare July 23, 2024 07:59
x/sponsorship/module.go Outdated Show resolved Hide resolved
x/sponsorship/types/codec.go Outdated Show resolved Hide resolved
x/sponsorship/keeper/genesis.go Show resolved Hide resolved
x/sponsorship/keeper/helpers.go Show resolved Hide resolved
x/sponsorship/keeper/invariants.go Outdated Show resolved Hide resolved
x/sponsorship/keeper/keeper.go Outdated Show resolved Hide resolved
x/sponsorship/types/msgs.go Outdated Show resolved Hide resolved
@keruch keruch requested a review from mtsitrin July 29, 2024 17:50
x/sponsorship/client/cli/tx_test.go Outdated Show resolved Hide resolved
x/sponsorship/keeper/genesis.go Show resolved Hide resolved
x/sponsorship/types/genesis.go Show resolved Hide resolved
proto/dymensionxyz/dymension/sponsorship/sponsorship.proto Outdated Show resolved Hide resolved
@keruch keruch force-pushed the kirill/sponsorship-module branch from 88099f3 to bd1a296 Compare August 5, 2024 08:08
@keruch keruch requested a review from mtsitrin August 5, 2024 08:09
@mtsitrin mtsitrin merged commit 695583c into main Aug 5, 2024
9 of 114 checks passed
@mtsitrin mtsitrin deleted the kirill/sponsorship-module branch August 5, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:sponsorship x/sponsorship module dym-internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants