Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sponsorship): added proto contracts #990

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Jul 12, 2024

Description

This PR adds proto contracts for the new x/sponsorship module following its specification.


Part of #983

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md <-- will add after the module scaffolding
  • Targeted PR against the correct branch
  • Included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests <-- is not needed now
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist <-- SDK is not used in this PR

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch added dym-internal c:sponsorship x/sponsorship module labels Jul 12, 2024
@keruch keruch requested review from srene, spoo-bar and mtsitrin July 12, 2024 19:39
@keruch keruch self-assigned this Jul 12, 2024
@keruch keruch requested a review from a team as a code owner July 12, 2024 19:39
@keruch keruch mentioned this pull request Jul 12, 2024
20 tasks
@keruch keruch linked an issue Jul 12, 2024 that may be closed by this pull request
20 tasks
@keruch keruch removed a link to an issue Jul 12, 2024
20 tasks
@keruch keruch linked an issue Jul 12, 2024 that may be closed by this pull request
20 tasks
@keruch keruch force-pushed the kirill/sponsorship-proto branch from 6bf5b05 to 27f393c Compare July 15, 2024 17:16
@keruch keruch requested a review from mtsitrin July 16, 2024 19:10
@keruch keruch force-pushed the kirill/sponsorship-proto branch from 495c334 to 85eb92d Compare July 17, 2024 17:11
@mtsitrin mtsitrin merged commit 54c0fca into main Jul 17, 2024
8 of 112 checks passed
@mtsitrin mtsitrin deleted the kirill/sponsorship-proto branch July 17, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:sponsorship x/sponsorship module dym-internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/sponsorship module
2 participants