Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eibc,delaydack): add validation to eibc and delayedack genesis state #967

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Jun 24, 2024

Description


Closes #942

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@zale144 zale144 self-assigned this Jun 24, 2024
@zale144 zale144 requested a review from a team as a code owner June 24, 2024 16:46
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 58.62069% with 24 lines in your changes missing coverage. Please review.

Project coverage is 28.72%. Comparing base (c3d9307) to head (30815ca).
Report is 10 commits behind head on main.

Current head 30815ca differs from pull request most recent head f18b751

Please upload reports for the commit f18b751 to get more accurate results.

Files Patch % Lines
x/common/types/rollapp_packet.go 28.57% 10 Missing and 5 partials ⚠️
x/eibc/types/params.go 52.63% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   29.15%   28.72%   -0.44%     
==========================================
  Files         243      256      +13     
  Lines       34148    33695     -453     
==========================================
- Hits         9957     9679     -278     
+ Misses      22710    22664      -46     
+ Partials     1481     1352     -129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

x/delayedack/types/genesis.go Outdated Show resolved Hide resolved
@zale144 zale144 force-pushed the zale144/942-add-missing-genesis-validation branch from 485cc6b to f18b751 Compare June 24, 2024 19:43
@mtsitrin mtsitrin merged commit fcd6081 into main Jun 25, 2024
8 of 88 checks passed
@mtsitrin mtsitrin deleted the zale144/942-add-missing-genesis-validation branch June 25, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing genesis validation
2 participants