Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra information to eibc order events #873

Closed
zale144 opened this issue May 9, 2024 · 2 comments · Fixed by #950
Closed

Add extra information to eibc order events #873

zale144 opened this issue May 9, 2024 · 2 comments · Fixed by #950
Assignees

Comments

@zale144
Copy link
Contributor

zale144 commented May 9, 2024

The eibc demand orders could use some extra information, such as the fulfiller address, block height when it was fulfilled and so on...
The reasoning is that these will be picked up by the indexer and made available for querying, which will come useful when tracking fulfilled demand orders, in particular for the funds tracking of the eibc-client.

@zale144 zale144 self-assigned this May 9, 2024
@omritoptix
Copy link
Contributor

I believe block height is not necessary as it's part of the event data anyway.

@danwt
Copy link
Contributor

danwt commented Jun 17, 2024

Sorry I'm not really familiar with how indexers work
But why can't it just be event data? Why does it need to get added to the business logic state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants