Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use errors.New to replace fmt.Errorf with no parameters #857

Merged
merged 2 commits into from
Apr 24, 2024
Merged

perf: use errors.New to replace fmt.Errorf with no parameters #857

merged 2 commits into from
Apr 24, 2024

Conversation

ChengenH
Copy link
Contributor

No description provided.

@ChengenH ChengenH requested a review from a team as a code owner April 20, 2024 07:58
@danwt
Copy link
Contributor

danwt commented Apr 22, 2024

I'm just curious what is this for?

@ChengenH
Copy link
Contributor Author

I'm just curious what is this for?

People tend to think that fmt.Errorf() need to format your error message prints something .
I think errors.Newf() is more clear.

@omritoptix omritoptix merged commit 2f0f1e2 into dymensionxyz:main Apr 24, 2024
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengenH @danwt @omritoptix