Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store corruption in fetching rollapp packets doesn't return error #741

Closed
omritoptix opened this issue Mar 27, 2024 · 1 comment · Fixed by #748
Closed

store corruption in fetching rollapp packets doesn't return error #741

omritoptix opened this issue Mar 27, 2024 · 1 comment · Fixed by #748
Assignees

Comments

@omritoptix
Copy link
Contributor

omritoptix commented Mar 27, 2024

Currently there are 2 places in rollapp packets where when we fail to unmarshal a specific packet we skip it and continue.
This may cause a corrupted state store which will continue to pile vs having the caller decide if the process should revert due to it.

the relevant places:
GetAllRollappPackets
ListRollappPacketsByStatus

The relevant code parts:

err := k.cdc.Unmarshal(iterator.Value(), &val)
		if err != nil {
                         ...
			continue
		}
@omritoptix omritoptix assigned omritoptix and danwt and unassigned omritoptix Mar 27, 2024
@danwt
Copy link
Contributor

danwt commented Mar 27, 2024

Similar cases

}
err := osmoutils.ApplyFuncIfNoError(ctx, wrapFn)
if err != nil {
k.Logger(ctx).Error("error unmarshalling demand order", "error", err.Error())
continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants