Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed incentives feature flag and decreased IRO MinEpochsPaidOver default value #1652

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Dec 12, 2024

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch requested a review from a team as a code owner December 12, 2024 15:50
@omritoptix omritoptix changed the title feat: removed incentives feature flag and increased IRO MinEpochsPaidOver default value feat: removed incentives feature flag and decreased IRO MinEpochsPaidOver default value Dec 12, 2024
@keruch keruch changed the title feat: removed incentives feature flag and decreased IRO MinEpochsPaidOver default value feat: removed incentives feature flag and increased IRO MinEpochsPaidOver default value Dec 12, 2024
@omritoptix omritoptix changed the title feat: removed incentives feature flag and increased IRO MinEpochsPaidOver default value feat: removed incentives feature flag and decreased IRO MinEpochsPaidOver default value Dec 12, 2024
@@ -29,7 +29,4 @@ message Params {
(gogoproto.nullable) = false,
(gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Int"
];
// FeatureFlagEpochEndDistribution enables distribution of gauge rewards
// at the end of each epoch. If disabled, rewards are not distributed.
bool feature_flag_epoch_end_distribution = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this flag already on Playground, remove like this won't cause trouble?

Copy link
Contributor Author

@keruch keruch Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't in theory. the first 4 fields are unchanged (which are actually used), so there should not be any serialization issues.

@omritoptix omritoptix merged commit 02cbaec into main Dec 12, 2024
5 checks passed
@omritoptix omritoptix deleted the kirill/remove-feature-flag branch December 12, 2024 16:12
omritoptix pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants