refactor(iro): refacor IRO creation fee #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
commented
Dec 8, 2024
| iroTokenBalance := k.BK.GetBalance(ctx, k.AK.GetModuleAddress(types.ModuleName), plan.TotalAllocation.Denom) | ||
| err := k.BK.BurnCoins(ctx, types.ModuleName, sdk.NewCoins(iroTokenBalance)) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // claim the fee token |
There was a problem hiding this comment.
we claim the tokens on creation instead
otherwise we need to handle the scenario where creationFee param changed
mtsitrin
commented
Dec 8, 2024
| @@ -91,7 +87,8 @@ func validateCreationFee(i interface{}) error { | |||
| return fmt.Errorf("invalid parameter type: %T", i) | |||
| } | |||
|
|
|||
| if !v.IsPositive() { | |||
| // creation fee must be a positive integer greater than 1^18 (1 Rollapp token) | |||
| if v.LT(math.NewIntWithDecimal(1, 18)) { | |||
There was a problem hiding this comment.
validation that creation fee is > 1
omritoptix
reviewed
Dec 8, 2024
x/iro/keeper/create_plan.go
Outdated
| return "", errorsmod.Wrap(gerrc.ErrInvalidArgument, "invalid cost for fee charge") | ||
| } | ||
|
|
||
| fee := sdk.NewCoin(appparams.BaseDenom, cost) |
There was a problem hiding this comment.
feeAmt and fee refer to 2 different things which I think is confusing.
omritoptix
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: