Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move expensive client state iteration to tx #1575

Merged
merged 23 commits into from
Nov 29, 2024
Merged

fix: move expensive client state iteration to tx #1575

merged 23 commits into from
Nov 29, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Nov 28, 2024

Description

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@danwt danwt changed the title Danwt/extract canon client fix: move expensive client state iteration Nov 28, 2024
@danwt danwt changed the title fix: move expensive client state iteration fix: move expensive client state iteration to tx Nov 28, 2024
@danwt danwt marked this pull request as ready for review November 28, 2024 21:54
@danwt danwt requested a review from a team as a code owner November 28, 2024 21:54
omritoptix
omritoptix approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong godoc as we don't validate the consensus state here anymore:

https://github.com/dymensionxyz/dymension/pull/1575/files#diff-ba4c5cafcc04b485b66198c72aa462b98bfc4d80ffda3be72b94daf83cc9570bL30-L32

VictorTrustyDev
VictorTrustyDev approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@VictorTrustyDev VictorTrustyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/lightclient/keeper/canonical_client.go Show resolved Hide resolved
x/rollapp/keeper/latest_state_info_index.go
if !ok {
return 0, false
}
return info.GetLatestHeight(), true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this guaranteed latest height > 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does it matter? If there is a state info, then the rollap definitely updated the hub

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then it's good

@omritoptix omritoptix merged commit e50f6de into main Nov 29, 2024
5 checks passed
@omritoptix omritoptix deleted the danwt/extract-canon-client branch November 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorTrustyDev VictorTrustyDev VictorTrustyDev approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danwt @omritoptix @VictorTrustyDev