Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sequencer): ensure sequencer cannot propose twice | graceful handling of non proposer in notice queue #1513

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Nov 19, 2024

Description

Does two things

  1. Makes sure that we don't expect seqs in the notice queue to be the proposer. Since, we don't clear the queue on hard fork. This was correct before but I removed the required if recently, for some reason.
  2. Check 'notice started' as potential proposer condition. It's actually needed to stop a proposer re-opting in after rotating out. As alternative solution, we could disable opt-in after notice started. I'm not bullish.

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@danwt danwt requested a review from a team as a code owner November 19, 2024 17:32
if err := k.setSuccessorForRotatingRollapp(ctx, seq.RollappId); err != nil {
return errorsmod.Wrap(err, "choose successor")

// Very important to check, because we do not explicitly remove sequencers from the queue: if they are forcibly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be cleaner to just k.removeFromNoticeQueue(ctx, seq) when proposer forcibly rotated

@danwt danwt requested a review from mtsitrin November 20, 2024 11:28
@mtsitrin mtsitrin merged commit bd6e324 into main Nov 20, 2024
5 checks passed
@mtsitrin mtsitrin deleted the danwt/fix-notice-queue branch November 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants